Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update templates CI workflow to use built templates #3481

Open
holic opened this issue Jan 21, 2025 · 1 comment
Open

update templates CI workflow to use built templates #3481

holic opened this issue Jan 21, 2025 · 1 comment

Comments

@holic
Copy link
Member

holic commented Jan 21, 2025

the templates workflow currently uses templates from their source with linked/workspace deps:
https://github.com/latticexyz/mud/blob/main/.github/workflows/templates.yml

ideally it should use the template output from pnpm create mud to mimic what users will see

hoping this will catch things like #3480 which the current workflow didn't catch

@holic
Copy link
Member Author

holic commented Jan 21, 2025

we should prob combine this with the template tests in create-mud's package:

"test:phaser": "bin/cli.js --name test-project --template phaser && pnpm --dir test-project install && shx rm -rf test-project",
"test:react": "bin/cli.js --name test-project --template react && pnpm --dir test-project install && shx rm -rf test-project",
"test:react-ecs": "bin/cli.js --name test-project --template react-ecs && pnpm --dir test-project install && shx rm -rf test-project",
"test:threejs": "bin/cli.js --name test-project --template threejs && pnpm --dir test-project install && shx rm -rf test-project",
"test:vanilla": "bin/cli.js --name test-project --template vanilla && pnpm --dir test-project install && shx rm -rf test-project"

maybe we can move all this into vitest instead of github action + npm scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant