-
Notifications
You must be signed in to change notification settings - Fork 193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically turn ascii --salt
into hex in deploy CLI
#3254
Comments
hi can i work on this? |
for sure! do you need pointers to get started? |
yes it would be great. |
This is the place where the error is thrown: mud/packages/cli/src/runDeploy.ts Lines 60 to 63 in 916aa8b
Instead of throwing the error we can encode the string as hex and continue |
thanks for the pointer after resolving i will ping you |
i have made the changes should i raise a PR so you can review the changes i am trying to send message in discord please allow me to send message |
yes, please open a PR with your changes |
i have made the PR |
The
mud deploy
CLI accepts a--salt
param for deterministic deployments. For better UX we should automatically encode any string that doesn't start with0x
to hex. (Right now it throws withMUDError: Expected hex string for salt
.)The text was updated successfully, but these errors were encountered: