Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feedback for “Add a system” #2861

Closed
ryanalbrecht opened this issue May 22, 2024 · 2 comments
Closed

Feedback for “Add a system” #2861

ryanalbrecht opened this issue May 22, 2024 · 2 comments

Comments

@ryanalbrecht
Copy link

Im still very new to this but there is a slight error in the code when using the default setup with the HelloWorld tutorial.

createSystemCall.ts should be app_decrement() instead of decrement() as the generated function name in packages\contracts\src\codegen\world\IDecrementSystem.sol is prefixed with app__

const decrement = async () => {
  const tx = await worldContract.write.app__decrement();
  await waitForTransaction(tx);
  return getComponentValue(Counter, singletonEntity);
};
@qbzzt
Copy link
Contributor

qbzzt commented May 22, 2024

Thank you. decrement() used to be correct, but then we changed the templates and didn't change the guide to match. I apologize. I just submitted a PR to fix this: #2859 .

@holic
Copy link
Member

holic commented May 23, 2024

fixed in #2859

@holic holic closed this as completed May 23, 2024
@github-project-automation github-project-automation bot moved this to Done in MUD May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants