Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

store sync should fetch block of latest block number alongside logs #2316

Open
holic opened this issue Feb 27, 2024 · 0 comments · May be fixed by #3394
Open

store sync should fetch block of latest block number alongside logs #2316

holic opened this issue Feb 27, 2024 · 0 comments · May be fixed by #3394

Comments

@holic
Copy link
Member

holic commented Feb 27, 2024

see #2315 (comment)

load balanced RPCs may be slightly out of sync, so when we get a notif for latest block number from a subscription, then fetch logs for that block number, the underlying rpc may not yet have the logs and return empty array

ideally we should fetch the block alongside the logs for that block to confirm the rpc has it, otherwise retry

(and need to handle/account for rpcs that don't support batch calling in this way)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging a pull request may close this issue.

1 participant