Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some basic e2e tests for getContract #1690

Open
holic opened this issue Oct 3, 2023 · 0 comments
Open

add some basic e2e tests for getContract #1690

holic opened this issue Oct 3, 2023 · 0 comments
Labels
good first issue Good for newcomers

Comments

@holic
Copy link
Member

holic commented Oct 3, 2023

our e2e tests missed that viem's gas estimation regressed after we bumped versions in #1684 (workaround fix in #1689)

we can probably catch these by making some regular ol' worldContract.write.someFunc() calls and testing that they go through without revert

@holic holic added the good first issue Good for newcomers label Oct 3, 2023
@holic holic changed the title add some basic e2e tests for createContract add some basic e2e tests for getContract Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant