Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consider renaming funcSelectorAndArgs to callData #1460

Closed
alvrs opened this issue Sep 12, 2023 · 1 comment · Fixed by #1524
Closed

consider renaming funcSelectorAndArgs to callData #1460

alvrs opened this issue Sep 12, 2023 · 1 comment · Fixed by #1524
Assignees
@holic
Milestone
v2 contracts stable

Comments

@alvrs
Copy link
Member

alvrs commented Sep 12, 2023

see https://github.com/latticexyz/mud/pull/1457/files#r1323479741
@alvrs alvrs added this to the Contracts stable milestone Sep 12, 2023
@alvrs alvrs mentioned this issue Sep 12, 2023
Merged
@holic
Copy link
Member

holic commented Sep 13, 2023

could also do encodedCall if we think callData would be confusing (but I think callData aligns well with msgSender and msgValue)

@alvrs alvrs self-assigned this Sep 16, 2023
@holic holic assigned holic and unassigned alvrs Sep 16, 2023
@holic holic mentioned this issue Sep 16, 2023
Merged
@holic holic moved this from Todo to Implementation in MUD v2 stable release (deprecated) Sep 16, 2023
@github-project-automation github-project-automation bot moved this from Implementation to Done in MUD v2 stable release (deprecated) Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@holic holic

Labels
None yet
Projects
No open projects
MUD v2 stable release (deprecated)
Status: Done
Milestone
v2 contracts stable
Development

Successfully merging a pull request may close this issue.

feat(world): rename funcSelectorAndArgs to callData latticexyz/mud
2 participants
@holic @alvrs