Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider renaming all mentions of "hook" to "hooks" #1406

Closed
alvrs opened this issue Sep 6, 2023 · 1 comment
Closed

Consider renaming all mentions of "hook" to "hooks" #1406

alvrs opened this issue Sep 6, 2023 · 1 comment
Assignees
@alvrs
Labels
good first issue Good for newcomers
Milestone
v2 contracts stable

Comments

@alvrs
Copy link
Member

alvrs commented Sep 6, 2023

Since #1399 introduced the ability to enable/disable individual hooks in an IStoreHook or ISystemHook contract, it might make sense to rename IStoreHook to IStoreHooks, ISystemHook to ISystemHooks, and all related variable names
@alvrs alvrs added the good first issue Good for newcomers label Sep 6, 2023
@alvrs alvrs added this to the Contracts stable milestone Sep 6, 2023
@alvrs alvrs self-assigned this Sep 11, 2023
@alvrs alvrs moved this from Todo to Implementation in MUD v2 stable release (deprecated) Sep 13, 2023
@alvrs alvrs moved this from Implementation to Spec in MUD v2 stable release (deprecated) Sep 13, 2023
@alvrs
Copy link
Member Author

alvrs commented Sep 15, 2023

Realized that it may still be better to call it IStoreHook, so that an array of hook contracts can be called hooks (and not hookses)

@alvrs alvrs closed this as completed Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alvrs alvrs

Labels
good first issue Good for newcomers
Projects
No open projects
MUD v2 stable release (deprecated)
Status: Done
Milestone
v2 contracts stable
Development

No branches or pull requests
1 participant
@alvrs