Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding resource type to resource selector #1394

Closed
holic opened this issue Sep 4, 2023 · 1 comment · Fixed by #1544
Closed

Consider adding resource type to resource selector #1394

holic opened this issue Sep 4, 2023 · 1 comment · Fixed by #1544
Assignees

Comments

@holic
Copy link
Member

holic commented Sep 4, 2023

Right now we generally use the pattern:

namespace (bytes16) + name (bytes16)

I am proposing we explore a pattern like:

resource type (bytes2) + namespace (bytes14) + name (bytes16)

This comes from seeing a few patterns emerge:

@alvrs
Copy link
Member

alvrs commented Sep 12, 2023

A semi-related thing to consider here is that we currently don't write to the ResourceType table if the table is registered directly via StoreCore instead of a call to world.registerTable (because ResourceType is a World concept, not a Store concept). Encoding the resource type in the selector might solve this if it means we don't need ResourceType anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

3 participants