Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gas-report: make it work within the context of MudTest #1334

Closed
holic opened this issue Aug 21, 2023 · 0 comments · Fixed by #1688
Closed

gas-report: make it work within the context of MudTest #1334

holic opened this issue Aug 21, 2023 · 0 comments · Fixed by #1688

Comments

@holic
Copy link
Member

holic commented Aug 21, 2023

if you run mud-gas-report on a thing that extends MudTest, it'll fail because it's missing a .mudtest file (created on MUD deploy)

since our deploy pipeline is separate (a TS script) from the rest of the foundry lifecycle, I think we should:

  • make gas-report (or sub command of) more of a pure "test output parser" rather than a "test runner"
  • allow overriding the test command used in the gas-report test runner

another wild idea: get MudTest to call out to TS deploy script during the test run, but not sure if there's an exposed RPC within the test runner we can thread through to the deploy process via CLI arg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant