Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gas-report: rename binary to just gas-report #1333

Closed
holic opened this issue Aug 21, 2023 · 2 comments · Fixed by #1410
Closed

gas-report: rename binary to just gas-report #1333

holic opened this issue Aug 21, 2023 · 2 comments · Fixed by #1410

Comments

@holic
Copy link
Member

holic commented Aug 21, 2023

It's not MUD specific so we can rename from mud-gas-report to gas-report and let ~anyone use it.
@dk1a
Copy link
Contributor

dk1a commented Aug 21, 2023

what do you think about a separate repo for it? (the package could still be @latticexyz/gas-report) It is indeed completely standalone and we could reduce our package number a bit.
btw I called it mud-gas-report mostly as an analogy to mud gas-report (the only way it could be called before the new package), no strong reason for that name

@holic
Copy link
Member Author

holic commented Aug 21, 2023

I think we should continue to publish packages from the monorepo, even if they could technically exist standalone.

@holic holic mentioned this issue Sep 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

style(gas-report): rename mud-gas-report to gas-report latticexyz/mud
2 participants
@holic @dk1a