Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move test tables out of store/world mud config #1309

Closed
holic opened this issue Aug 15, 2023 · 1 comment · Fixed by #1600
Closed

move test tables out of store/world mud config #1309

holic opened this issue Aug 15, 2023 · 1 comment · Fixed by #1600
Assignees

Comments

@holic
Copy link
Member

holic commented Aug 15, 2023

Apps shouldn't be deploying our test tables like Mixed and Vector2 and AddressArray such. These should get moved into some test dir.

Mixed: {
schema: {
u32: "uint32",
u128: "uint128",
a32: "uint32[]",
s: "string",
},
},
Vector2: {
schema: {
x: "uint32",
y: "uint32",
},
},
KeyEncoding: {
keySchema: {
k1: "uint256",
k2: "int32",
k3: "bytes16",
k4: "address",
k5: "bool",
k6: "ExampleEnum",
},
schema: "bool",
},

Mixed: {
schema: {
u32: "uint32",
u128: "uint128",
a32: "uint32[]",
s: "string",
},
},
Vector2: {
schema: {
x: "uint32",
y: "uint32",
},
},
KeyEncoding: {
keySchema: {
k1: "uint256",
k2: "int32",
k3: "bytes16",
k4: "address",
k5: "bool",
k6: "ExampleEnum",
},
schema: "bool",
},

@holic holic changed the title move test tables out of store's mud config move test tables out of store/world mud config Aug 15, 2023
@holic holic added this to the Contracts stable milestone Aug 15, 2023
@alvrs alvrs self-assigned this Sep 11, 2023
@alvrs alvrs assigned holic and unassigned alvrs Sep 18, 2023
@holic holic moved this from Planned to Next up in MUD v2 stable release (deprecated) Sep 18, 2023
@alvrs
Copy link
Member

alvrs commented Sep 24, 2023

could do that by generating these manually from a script for now, like in CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

2 participants