From e667ee808b5362ff215ba3faea028b526660eccb Mon Sep 17 00:00:00 2001
From: Kevin Ingersoll <kingersoll@gmail.com>
Date: Fri, 13 Oct 2023 09:23:02 +0100
Subject: [PATCH] feat(cli): remove forge clean from deploy (#1759)

---
 .changeset/silent-carrots-glow.md          |  5 +++++
 packages/cli/src/commands/dev-contracts.ts |  1 -
 packages/cli/src/runDeploy.ts              | 11 +----------
 3 files changed, 6 insertions(+), 11 deletions(-)
 create mode 100644 .changeset/silent-carrots-glow.md

diff --git a/.changeset/silent-carrots-glow.md b/.changeset/silent-carrots-glow.md
new file mode 100644
index 0000000000..faf0c8f660
--- /dev/null
+++ b/.changeset/silent-carrots-glow.md
@@ -0,0 +1,5 @@
+---
+"@latticexyz/cli": minor
+---
+
+CLI `deploy`, `test`, `dev-contracts` no longer run `forge clean` before each deploy. We previously cleaned to ensure no outdated artifacts were checked into git (ABIs, typechain types, etc.). Now that all artifacts are gitignored, we can let forge use its cache again.
diff --git a/packages/cli/src/commands/dev-contracts.ts b/packages/cli/src/commands/dev-contracts.ts
index 2cbfe1b062..6ef7fd6da7 100644
--- a/packages/cli/src/commands/dev-contracts.ts
+++ b/packages/cli/src/commands/dev-contracts.ts
@@ -76,7 +76,6 @@ const commandModule: CommandModule<typeof devOptions, InferredOptionTypes<typeof
         const deploy = await runDeploy({
           configPath,
           rpc,
-          clean: true,
           skipBuild: false,
           printConfig: false,
           profile: undefined,
diff --git a/packages/cli/src/runDeploy.ts b/packages/cli/src/runDeploy.ts
index 885cfa2d62..0a5f370a70 100644
--- a/packages/cli/src/runDeploy.ts
+++ b/packages/cli/src/runDeploy.ts
@@ -1,5 +1,5 @@
 import path from "node:path";
-import { existsSync, mkdirSync, readFileSync, writeFileSync } from "node:fs";
+import { existsSync, mkdirSync, readFileSync, rmSync, writeFileSync } from "node:fs";
 import { InferredOptionTypes, Options } from "yargs";
 import { deploy } from "./deploy/deploy";
 import { createWalletClient, http, Hex } from "viem";
@@ -19,11 +19,6 @@ import { tablegen } from "@latticexyz/store/codegen";
 
 export const deployOptions = {
   configPath: { type: "string", desc: "Path to the config file" },
-  clean: {
-    type: "boolean",
-    desc: "Remove the build forge artifacts and cache directories before building",
-    default: false,
-  },
   printConfig: { type: "boolean", desc: "Print the resolved config" },
   profile: { type: "string", desc: "The foundry profile to use" },
   saveDeployment: { type: "boolean", desc: "Save the deployment info to a file", default: true },
@@ -58,10 +53,6 @@ export async function runDeploy(opts: DeployOptions): Promise<WorldDeploy> {
     )
   );
 
-  if (opts.clean) {
-    await forge(["clean"], { profile });
-  }
-
   // Run forge build
   if (!opts.skipBuild) {
     const outPath = path.join(srcDir, config.codegenDirectory);