From d15144d8bb13a250f7f9e31dc4505e6d6cce0590 Mon Sep 17 00:00:00 2001 From: alvrs Date: Fri, 22 Sep 2023 18:48:25 +0100 Subject: [PATCH] gas report --- packages/world/gas-report.json | 20 +++++++++---------- .../interfaces/IWorldRegistrationSystem.sol | 2 +- .../StoreRegistrationSystem.sol | 2 ++ 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/packages/world/gas-report.json b/packages/world/gas-report.json index 6c814fd6ad..841444eae3 100644 --- a/packages/world/gas-report.json +++ b/packages/world/gas-report.json @@ -99,7 +99,7 @@ "file": "test/KeysWithValueModule.t.sol", "test": "testGetKeysWithValueGas", "name": "install keys with value module", - "gasUsed": 656381 + "gasUsed": 656403 }, { "file": "test/KeysWithValueModule.t.sol", @@ -117,7 +117,7 @@ "file": "test/KeysWithValueModule.t.sol", "test": "testInstall", "name": "install keys with value module", - "gasUsed": 656381 + "gasUsed": 656403 }, { "file": "test/KeysWithValueModule.t.sol", @@ -129,7 +129,7 @@ "file": "test/KeysWithValueModule.t.sol", "test": "testSetAndDeleteRecordHook", "name": "install keys with value module", - "gasUsed": 656381 + "gasUsed": 656403 }, { "file": "test/KeysWithValueModule.t.sol", @@ -147,7 +147,7 @@ "file": "test/KeysWithValueModule.t.sol", "test": "testSetField", "name": "install keys with value module", - "gasUsed": 656381 + "gasUsed": 656403 }, { "file": "test/KeysWithValueModule.t.sol", @@ -255,7 +255,7 @@ "file": "test/UniqueEntityModule.t.sol", "test": "testInstall", "name": "install unique entity module", - "gasUsed": 678480 + "gasUsed": 684458 }, { "file": "test/UniqueEntityModule.t.sol", @@ -267,7 +267,7 @@ "file": "test/UniqueEntityModule.t.sol", "test": "testInstallRoot", "name": "installRoot unique entity module", - "gasUsed": 645328 + "gasUsed": 651262 }, { "file": "test/UniqueEntityModule.t.sol", @@ -309,19 +309,19 @@ "file": "test/World.t.sol", "test": "testRegisterFunctionSelector", "name": "Register a function selector", - "gasUsed": 78378 + "gasUsed": 84366 }, { "file": "test/World.t.sol", "test": "testRegisterNamespace", "name": "Register a new namespace", - "gasUsed": 123261 + "gasUsed": 123283 }, { "file": "test/World.t.sol", "test": "testRegisterRootFunctionSelector", "name": "Register a root function selector", - "gasUsed": 74921 + "gasUsed": 81417 }, { "file": "test/World.t.sol", @@ -333,7 +333,7 @@ "file": "test/World.t.sol", "test": "testRegisterTable", "name": "Register a new table in the namespace", - "gasUsed": 641197 + "gasUsed": 641193 }, { "file": "test/World.t.sol", diff --git a/packages/world/src/interfaces/IWorldRegistrationSystem.sol b/packages/world/src/interfaces/IWorldRegistrationSystem.sol index 9fa5f397b7..5880071b4b 100644 --- a/packages/world/src/interfaces/IWorldRegistrationSystem.sol +++ b/packages/world/src/interfaces/IWorldRegistrationSystem.sol @@ -23,7 +23,7 @@ interface IWorldRegistrationSystem { function registerRootFunctionSelector( ResourceId systemId, - string calldata worldFunctionSignature, + string memory worldFunctionSignature, bytes4 systemFunctionSelector ) external returns (bytes4 worldFunctionSelector); diff --git a/packages/world/src/modules/core/implementations/StoreRegistrationSystem.sol b/packages/world/src/modules/core/implementations/StoreRegistrationSystem.sol index 607d598793..9b91816493 100644 --- a/packages/world/src/modules/core/implementations/StoreRegistrationSystem.sol +++ b/packages/world/src/modules/core/implementations/StoreRegistrationSystem.sol @@ -23,6 +23,8 @@ import { SystemRegistry } from "../tables/SystemRegistry.sol"; import { Systems } from "../tables/Systems.sol"; import { FunctionSelectors } from "../tables/FunctionSelectors.sol"; +import { CORE_SYSTEM_ID } from "../constants.sol"; + import { WorldRegistrationSystem } from "./WorldRegistrationSystem.sol"; /**