From 5c965a919355bf98d7ea69463890fe605bcde206 Mon Sep 17 00:00:00 2001 From: alvarius Date: Thu, 3 Aug 2023 19:10:48 +0100 Subject: [PATCH] fix(store): align Store event names between IStoreWrite and StoreCore (#1237) --- .changeset/large-hats-walk.md | 5 +++++ packages/store/abi/StoreCore.sol/StoreCore.abi.json | 6 +++--- packages/store/src/StoreCore.sol | 6 +++--- packages/world/abi/StoreCore.sol/StoreCore.abi.json | 6 +++--- packages/world/abi/src/StoreCore.sol/StoreCore.abi.json | 6 +++--- 5 files changed, 17 insertions(+), 12 deletions(-) create mode 100644 .changeset/large-hats-walk.md diff --git a/.changeset/large-hats-walk.md b/.changeset/large-hats-walk.md new file mode 100644 index 0000000000..f8485a09aa --- /dev/null +++ b/.changeset/large-hats-walk.md @@ -0,0 +1,5 @@ +--- +"@latticexyz/store": patch +--- + +Align Store events parameter naming between IStoreWrite and StoreCore diff --git a/packages/store/abi/StoreCore.sol/StoreCore.abi.json b/packages/store/abi/StoreCore.sol/StoreCore.abi.json index 2800cfc6ff..72f144fcd2 100644 --- a/packages/store/abi/StoreCore.sol/StoreCore.abi.json +++ b/packages/store/abi/StoreCore.sol/StoreCore.abi.json @@ -5,7 +5,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { @@ -49,7 +49,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { @@ -80,7 +80,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { diff --git a/packages/store/src/StoreCore.sol b/packages/store/src/StoreCore.sol index af407d6009..8798bd85cf 100644 --- a/packages/store/src/StoreCore.sol +++ b/packages/store/src/StoreCore.sol @@ -18,9 +18,9 @@ library StoreCore { using TableId for bytes32; // note: the preimage of the tuple of keys used to index is part of the event, so it can be used by indexers - event StoreSetRecord(bytes32 tableId, bytes32[] key, bytes data); - event StoreSetField(bytes32 tableId, bytes32[] key, uint8 schemaIndex, bytes data); - event StoreDeleteRecord(bytes32 tableId, bytes32[] key); + event StoreSetRecord(bytes32 table, bytes32[] key, bytes data); + event StoreSetField(bytes32 table, bytes32[] key, uint8 schemaIndex, bytes data); + event StoreDeleteRecord(bytes32 table, bytes32[] key); event StoreEphemeralRecord(bytes32 table, bytes32[] key, bytes data); /** diff --git a/packages/world/abi/StoreCore.sol/StoreCore.abi.json b/packages/world/abi/StoreCore.sol/StoreCore.abi.json index 2800cfc6ff..72f144fcd2 100644 --- a/packages/world/abi/StoreCore.sol/StoreCore.abi.json +++ b/packages/world/abi/StoreCore.sol/StoreCore.abi.json @@ -5,7 +5,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { @@ -49,7 +49,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { @@ -80,7 +80,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { diff --git a/packages/world/abi/src/StoreCore.sol/StoreCore.abi.json b/packages/world/abi/src/StoreCore.sol/StoreCore.abi.json index 2800cfc6ff..72f144fcd2 100644 --- a/packages/world/abi/src/StoreCore.sol/StoreCore.abi.json +++ b/packages/world/abi/src/StoreCore.sol/StoreCore.abi.json @@ -5,7 +5,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { @@ -49,7 +49,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, { @@ -80,7 +80,7 @@ { "indexed": false, "internalType": "bytes32", - "name": "tableId", + "name": "table", "type": "bytes32" }, {