From 109bea9f96c35cd6c6f1322f2b9d3cc8bdfa7a99 Mon Sep 17 00:00:00 2001 From: maddyscientist Date: Wed, 4 May 2016 14:55:49 -0700 Subject: [PATCH 1/2] Fixed inconsistent reporting of dslash_test if a process fails other than process 0 --- lib/color_spinor_util.cu | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/lib/color_spinor_util.cu b/lib/color_spinor_util.cu index 1be8e80b0d..856aad3e72 100644 --- a/lib/color_spinor_util.cu +++ b/lib/color_spinor_util.cu @@ -177,6 +177,10 @@ namespace quda { } } + // reduce over all processes + for (int i=0; i Date: Wed, 4 May 2016 15:07:57 -0700 Subject: [PATCH 2/2] Silence valgind warning about jump or move depending on uninitialised value --- lib/tune.cpp | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/tune.cpp b/lib/tune.cpp index b63dc167ba..7889039fc4 100644 --- a/lib/tune.cpp +++ b/lib/tune.cpp @@ -133,7 +133,7 @@ namespace quda { TuneKey key = entry->first; TuneParam param = entry->second; - char tmp[7]; + char tmp[7] = { }; strncpy(tmp, key.aux, 6); bool is_policy = strcmp(tmp, "policy") == 0 ? true : false; if (param.n_calls > 0 && !is_policy) total_time += param.n_calls * param.time; @@ -145,8 +145,8 @@ namespace quda { TuneKey key = q.top().first; TuneParam param = q.top().second; - char tmp[7]; - strncpy(tmp, key.aux,6); + char tmp[7] = { }; + strncpy(tmp, key.aux, 6); bool is_policy = strcmp(tmp, "policy") == 0 ? true : false; // synchronous profile @@ -405,7 +405,7 @@ namespace quda { int n_policy = 0; for (map::iterator entry = tunecache.begin(); entry != tunecache.end(); entry++) { // if a policy entry, then we can ignore - char tmp[6]; + char tmp[7] = { }; strncpy(tmp, entry->first.aux, 6); TuneParam param = entry->second; bool is_policy = strcmp(tmp, "policy") == 0 ? true : false;