Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace intervention/image #1187

Open
driesvints opened this issue Nov 22, 2024 · 1 comment · May be fixed by #1189
Open

Replace intervention/image #1187

driesvints opened this issue Nov 22, 2024 · 1 comment · May be fixed by #1189
Labels
enhancement help wanted

Comments

@driesvints
Copy link
Member

We can't seem to upgrade to v3 because they removed the ability to output images as responses: https://image.intervention.io/v3/introduction/upgrade

We'll need to figure out a new way to generate social images.
@tauseefsshah tauseefsshah linked a pull request Nov 23, 2024 that will close this issue
Open
@tauseefsshah
Copy link
Contributor

@driesvints I found a way around this using laravel's response(). The solution works you can try the PR code #1189 and let me know what you think of the approach.

I will also write tests for this code because currently it's not tested. (I don't know how to test dynamic images but hopefully will figure out soon 😅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Upgrade to intervantion v3 tauseefsshah/laravel.io
2 participants
@driesvints @tauseefsshah