-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
valet isolate
does not work for linked sites with a different name to the folder
#1206
Comments
Ahhh... so I tested this in a circumstance where it was linked both as the folder's name and as another name, and that worked for me. Just to make sure I'm right, could you test linking I'll have to think a bit about a solution for this so getting the results of your test will help a bit. Thanks! |
That works (thank you!) Sounds like you understand that's a workaround: isolating the linked site name would be best. For example, if I needed PHP version isolation for two different repos called |
Quick Thought: What would be the best way to run composer/artisan/tests on the site's PHP version? Could Valet put a |
Yah.. I know this is a workaround, I'm just not 100% sure how to solve it, because the entire implementation right now is based on the directory being mapped to the linked site, so i'll probably have to add a flag that allows you to override it automatically reading the directory. Something like: valet isolate php@7.4 --site=backend |
@adrianb93 I've just merged what I think is a fix into the Thanks! |
Gonna just tag a release :) |
Hey, sorry. Had a busy few days. The |
Description:
valet isolate
does not work for linked sites with a different name to the folder.For example, the
~/Code/backend
project is linked with the namecompany-name
.The command does not have an option to specify the site name. Suggestion:
Steps To Reproduce:
Diagnosis
sw_vers
valet --version
cat ~/.config/valet/config.json
cat ~/.composer/composer.json
composer global diagnose
composer global outdated
ls -al /etc/sudoers.d/
brew config
brew services list
brew list --formula --versions | grep -E "(php|nginx|dnsmasq|mariadb|mysql|mailhog|openssl)(@\d\..*)?\s"
brew outdated
brew tap
php -v
which -a php
php --ini
nginx -v
curl --version
php --ri curl
~/.composer/vendor/laravel/valet/bin/ngrok version
~/.composer/vendor/laravel/valet/bin/ngrok-arm version
ls -al ~/.ngrok2
brew info nginx
brew info php
brew info openssl
openssl version -a
openssl ciphers
sudo nginx -t
which -a php-fpm
/opt/homebrew/opt/php/sbin/php-fpm -v
sudo /opt/homebrew/opt/php/sbin/php-fpm -y /opt/homebrew/etc/php/8.1/php-fpm.conf --test
ls -al ~/Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchAgents | grep homebrew
ls -al /Library/LaunchDaemons | grep homebrew
ls -al /Library/LaunchDaemons | grep "com.laravel.valet."
ls -aln /etc/resolv.conf
cat /etc/resolv.conf
ifconfig lo0
sh -c 'echo "------\n/opt/homebrew/etc/nginx/valet/valet.conf\n---\n"; cat /opt/homebrew/etc/nginx/valet/valet.conf | grep -n "# valet loopback"; echo "\n------\n"'
sh -c 'for file in ~/.config/valet/dnsmasq.d/*; do echo "------\n~/.config/valet/dnsmasq.d/$(basename $file)\n---\n"; cat $file; echo "\n------\n"; done'
The text was updated successfully, but these errors were encountered: