Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthorizedAccessTokenController->destroy returns void on success #687

Closed
goodevilgenius opened this issue Apr 6, 2018 · 3 comments
Closed
Labels

Comments

@goodevilgenius
Copy link

When a token is successfully deleted, a valid response should be returned (probably new Response('', 204).

However, nothing is returned, resulting in an error.

@goodevilgenius
Copy link
Author

Sorry about this. My frontend guys told me there was an error, and I didn't double-check it. This actually does return a valid response.

@michaelklopf
Copy link

Similar situation here, Ember expects a response, but the one coming is no fit for Ember.

https://stackoverflow.com/questions/20648372/what-does-ember-data-expect-in-response-to-deleting-a-record

@driesvints
Copy link
Member

Seems like this is indeed a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants