ID::make() should use model's primary key

[rcknr]

ID::make() assumes that primary key is id which often isn't the case. Why not default to Model::getModel()->getKeyName() instead?

[MattMangoni]

I wouldn't say 'often', but yeah, this is something to take into account :)

[devmsh]

What version you use?

public static function forModel($model)
    {
        return tap(static::make('ID', $model->getKeyName()))->resolve($model);
    }

ID currently use getKeyName as you mention

[davidhemphill]

As @devmsh posted, the ID field uses the value from getKeyName().

[rcknr]

For the reference, it should be used like so:

ID::forModel($this->model())