Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full width metrics getting cropped #1698

Closed
robinstraub opened this issue Jun 25, 2019 · 11 comments
Closed

full width metrics getting cropped #1698

robinstraub opened this issue Jun 25, 2019 · 11 comments
Labels
bug Verified bug by the Nova team
Milestone

Comments

@robinstraub
Copy link

Metrics with full width are getting cropped.

Versions:

  • Laravel Version: 5.8.23
  • Nova Version: 2.0.6
  • PHP Version: 7.3
  • Operating System and Version: MacOS 10.14.5
  • Browser type and version: Chrome 75.0.3770.100

Description:

When I define a metric width ((new CustomMetric)->width('full'),) and set it as full, the rendering gets cropped.

image

On the other side it is fine on other sizes (1/2 or 1/3). After looking at the DOM, the card-panel class appears missing. Is this an expected behavior ?

Steps To Reproduce:

  • Create a custom metric
  • Set the width to full
@cwcrawley
Copy link

Subscribing to this as I'm experiencing the same behaviour.

Laravel Version: 5.8.29
Nova Version: 2.0.9
PHP Version: 7.1.19
Operating System and Version : MacOS 10.14.5
Browser: Firefox Developer Edition 69.0b5

@jbrooksuk jbrooksuk added the bug Verified bug by the Nova team label Jul 31, 2019
@jbrooksuk
Copy link
Member

Confirmed in v2.0.9

If you resize the window, the chart redraws and stops cutting off.

@jbrooksuk jbrooksuk added this to the v2.0 milestone Aug 1, 2019
@jbrooksuk
Copy link
Member

This no longer happens in v2.0.10:

image

@mvdnbrk
Copy link

mvdnbrk commented Aug 14, 2019

@jbrooksuk This issue does not seem to be resolved.

Nova v2.0.11

@jbrooksuk
Copy link
Member

@mvdnbrk have you ran php artisan nova:publish? Again, this isn't happening on v2.0.11 for me:

image

@Ahmed-creatify
Copy link

the same issue here

@MorganeMeganck
Copy link

MorganeMeganck commented Feb 6, 2020

I have the same issue :( on v2.10.0
novadash

@jbrooksuk
Copy link
Member

What happens if you select a different timeframe and then switch back, does it correct itself?

@MorganeMeganck
Copy link

Yes it does

@mvdnbrk
Copy link

mvdnbrk commented Feb 7, 2020

Setting width to full results is the following HTML:

<div class="px-3 mb-6 w-full">
    <div class="card relative px-6 py-4">
        ....
    <div>
</div>

Like @robinstraub mentioned earlier the card-panel class is missing.
The card-panel class sets the height to 150px.

<div class="px-3 mb-6 w-full">
    <div class="card relative px-6 py-4 card-panel">
        ....
    <div>
</div>

@github-actions
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Verified bug by the Nova team
Projects
None yet
Development

No branches or pull requests

6 participants