Is this a bug?

[mariusghitoiu]

In Nova 4, latest at the moment, 4.32.9 I noticed the following situation:

• In MenuItem, if I set the name of the item in the menu, this is translated in jsonSerialize method

public function jsonSerialize(): array
    {
        $url = URL::make($this->path, $this->external);

        $activeMenuCallback = $this->activeMenuCallback ?? function ($request, URL $url) {
            return $url->active();
        };

        return [
            'name' => Nova::__($this->name), //here
            'component' => $this->component,
            'path' => (string) $url,
            'external' => $this->external,
            'target' => $this->target,
            'method' => $this->method,
            'data' => $this->data,
            'headers' => $this->headers,
            'active' => value($activeMenuCallback, request(), $url),
            'badge' => $this->resolveBadge(),
        ];
    }

My expectation was that this should be translated before it gets to this method, in MenuSection in NovaServiceProvider like this
MenuItem::resource(Certificate::class)->name(__('Certificates')),

The interesting part is that the translation for Certificates in romanian is Certificate, but then this is also the singular from certificates in english, which then is translated in romanian with Certificat, so I end up in my menu with the singular translation of Certificates instead of the plural.

My fix to this was to set the label and singularLabel in resource like this, even if it doesn't feel right.

public static function label()
    {
        return 'Certificate';
    }

    /**
     * Get the displayable singular label of the resource.
     *
     * @return string
     */
    public static function singularLabel()
    {
        return 'Certificat';
    }

Should the name be translated in jsonSerialize? I am thinking there might be other use cases where this is necessary.