Skip to content
This repository has been archived by the owner on Jul 16, 2021. It is now read-only.

[Feature Request] Ignore verificationUrl() when you proxy a VerifyEmail #1635

Open
ludo237 opened this issue May 10, 2019 · 2 comments
Open

Comments

@ludo237
Copy link

ludo237 commented May 10, 2019

This feature request is related to this issue that I've posted.

I think that the VerifyEmail notification class should ignore the verificationUrl when you proxy it.

What do you think?

@PHPGuus
Copy link

PHPGuus commented Sep 8, 2020

Hi there,

I rather think that VerifyEmailnotification should have a similar interface to ResetPassword notification in that you can proxy both the mail generation and the URL generation using createUrlUsing() and toMailUsing() in both notifications.

@driesvints would you agree with that? If so, I'll PR one against Laravel 7 and one against Laravel 8.

Thanks and best regards,
Guus

@PHPGuus
Copy link

PHPGuus commented Sep 8, 2020

Sorry... My particular use case is that I want to overwrite the verification.verify route onto a different domain than the API (VueJS app is hosted on a subdomain different than the API will be), so I would use the same temporarySignedRoute as the current implementation, but I would (in my own project) proxy it to force an absolute path.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants