Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHP 8.1] Deprecation message #1099

Closed
robsontenorio opened this issue Dec 1, 2021 · 1 comment · Fixed by #1100
Closed

[PHP 8.1] Deprecation message #1099

robsontenorio opened this issue Dec 1, 2021 · 1 comment · Fixed by #1100
Labels

Comments

@robsontenorio
Copy link

"php": "^8.1",
"laravel/framework": "^8.73",
"laravel/horizon": "^5.7"

Currently in horizon/src/JobPayload.php. Probably other methods should be type hinted.

Return type of Laravel\Horizon\JobPayload::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in /var/www/app/vendor/laravel/horizon/src/JobPayload.php 
@driesvints
Copy link
Member

Thanks, I've sent in a PR for this: #1100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants