From 2d7c8203eb4b07a53a1a85ffceac0bf3bf28907b Mon Sep 17 00:00:00 2001 From: faissaloux Date: Tue, 4 Jun 2024 00:11:29 +0100 Subject: [PATCH 1/2] turn Enumerable unless() parameter optional --- src/Illuminate/Collections/Enumerable.php | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/Illuminate/Collections/Enumerable.php b/src/Illuminate/Collections/Enumerable.php index 918f64758e66..4a06fac13630 100644 --- a/src/Illuminate/Collections/Enumerable.php +++ b/src/Illuminate/Collections/Enumerable.php @@ -338,11 +338,11 @@ public function whenNotEmpty(callable $callback, callable $default = null); * @template TUnlessReturnType * * @param bool $value - * @param (callable($this): TUnlessReturnType) $callback + * @param (callable($this): TUnlessReturnType)|null $callback * @param (callable($this): TUnlessReturnType)|null $default * @return $this|TUnlessReturnType */ - public function unless($value, callable $callback, callable $default = null); + public function unless($value, callable $callback = null, callable $default = null); /** * Apply the callback unless the collection is empty. From 67e12f2625849edf3379ba023d7e17d118aa14bf Mon Sep 17 00:00:00 2001 From: faissaloux Date: Tue, 4 Jun 2024 01:53:33 +0100 Subject: [PATCH 2/2] nullable parameters declaration --- src/Illuminate/Collections/Enumerable.php | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/Illuminate/Collections/Enumerable.php b/src/Illuminate/Collections/Enumerable.php index 4a06fac13630..c9fb24fa1fac 100644 --- a/src/Illuminate/Collections/Enumerable.php +++ b/src/Illuminate/Collections/Enumerable.php @@ -342,7 +342,7 @@ public function whenNotEmpty(callable $callback, callable $default = null); * @param (callable($this): TUnlessReturnType)|null $default * @return $this|TUnlessReturnType */ - public function unless($value, callable $callback = null, callable $default = null); + public function unless($value, ?callable $callback = null, ?callable $default = null); /** * Apply the callback unless the collection is empty.