Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] Fix timezone option in schedule:list command #40304

Merged
merged 2 commits into from
Jan 7, 2022
Merged

[8.x] Fix timezone option in schedule:list command #40304

merged 2 commits into from
Jan 7, 2022

Conversation

royvanv
Copy link
Contributor

@royvanv royvanv commented Jan 7, 2022

Currently php artisan schedule:list fails with the following error:

 DateTime::setTimezone(): Argument #1 ($timezone) must be of type DateTimeZone, string given

This PR converts the timezone value from a string to an instance of DateTimeZone. It also sets default value with null coalescing check, because the options method does not have a 2nd parameter.

@GrahamCampbell GrahamCampbell changed the title Fix timezone option in schedule:list command [8.x] Fix timezone option in schedule:list command Jan 7, 2022
@taylorotwell taylorotwell merged commit 926cde9 into laravel:8.x Jan 7, 2022
@royvanv royvanv deleted the schedule-list-command-timezone branch January 7, 2022 17:33
@seriquynh seriquynh mentioned this pull request Jan 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@royvanv @taylorotwell