[6.x] Use a map to prevent unnecessary array access

[jasonvarga]

I'm sure I'll get the "resources are an eloquent feature" response, but it's so great for us to use without needing to reinvent any wheels, and this is a tiny change so I thought it's worth a shot.

This change introduced a while back broke paginated API resources where people weren't using Eloquent models.

There are a bunch of issues #29858, #29916, #31703, #31704 (probably others) related to it.

This PR fixes the root cause for most of them. By changing from pluck to map, we avoid an array access call to the Eloquent model (or non-Eloquent model in our cases) that happens further down the stack trace. It'll let those of us who still want to use Resources to avoid ugly workarounds.

[jasonvarga]

Thanks! 🎉

[driesvints]

@jasonvarga I guess this is an acceptable workaround, thanks for the pr.

But like you said I again want to stress that resources are designed to work with Eloquent models so you could still run into problems at some point.

[jasonvarga]

I'm fine with taking that risk. The alternative would be to make our own nearly identical implementation. 😬

[mholmes-hs]

Seems to break my code

        $query = Pet::where('shelter_id', $shelter->id);
        if($searchValue) {
            $query = $query->where('shelter_reference', 'like', "$searchValue%");
        }
        if($orderBy) {
         $query = $query->orderBy($orderBy, $orderByDir);
        }
        $data = $query->paginate($length);

        $data
            ->getCollection()
            ->transform(function($pet) {
                return [
                    'uuid' => $pet->uuid,
                    'shelter_reference' => "#$pet->shelter_reference",
                    'dueout_date' => $pet->dueout_date
                        ? $pet->dueout_date->format('m/d/Y')
                        : null,
                    'intake_date' => $pet->intake_date->format('m/d/Y'),
                    'is_published' => $pet->is_published ? 'Published' : 'Draft',
                    'amount_raised' => "$$pet->amount_raised",
                    'id' => $pet->id,
                    'type' => $pet->type,
                ];
            }); ```

[Shhu]

It break my code too with a kinda misleading error
Trying to get property 'resource' of non-object'

Had to replace
'data' => $this->collection->transform(static function (User $user) {
with
'data' => $this->collectResource($this->collection)->transform(static function (User $user) {

[driesvints]

@mholmes-hs @Shhu can one of you two please open up an issue and add full steps to reproduce? Please try to keep the code as minimal as possible to reproduce.

[Shhu]

@driesvints done with #32513

[edwink75]

It break my code too with a kinda misleading error
Trying to get property 'resource' of non-object'

Had to replace
'data' => $this->collection->transform(static function (User $user) {
with
'data' => $this->collectResource($this->collection)->transform(static function (User $user) {

This works like a charm, thank you!