Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.x] Change File cache store permission to not chmod if not set. #31593

Merged
merged 2 commits into from
Feb 26, 2020
Merged

[6.x] Change File cache store permission to not chmod if not set. #31593

merged 2 commits into from
Feb 26, 2020

Conversation

matt-h
Copy link
Contributor

@matt-h matt-h commented Feb 26, 2020

This reverts some of the behavior in 61b5aa1
From pull request #31579

With that change, if you did not set a permission in your config file ( a new feature not yet in https://github.com/laravel/laravel ) it would now default to 0775 for the permission.
The previous behavior was to use whatever was the system default, which on most Linux systems would actually be 0644 instead of 0775.

In addition an additional chmod system call would be issued after every file write.

This change restores the previous behavior while still allowing you to set the config to override the permission to whatever you like.

matt-h and others added 2 commits February 26, 2020 01:03
not issue a chmod call.

This reverts some of the behavior in 61b5aa1
From pull request #31579
@taylorotwell taylorotwell merged commit 09101f7 into laravel:6.x Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants