[6.x] Fix dropping columns with default value #31341
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt_object_id is not 0.
yarik3351
changed the title
|
@yarik3351 thanks for the fix, i was still looking into it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4402
Select only rows where default_object_id is not 0.
A little modification of #31229 as fix from it did not work for a migration.
It appears that SQL query generated by #31229 selects all columns and take their [default_object_id] field but columns without default value have [default_object_id] = 0.
This pull request adds another condition to the query to take only fields where [default_object_id] !== 0.
End result
There in no need to specify dropping default constraints manually like proposed in issues like: #4402Tests
Tests from original PR #31229 are suitable.