[6.x] Fix the Filesystem manager's exception on unsupported driver

[arcanedev-maroc]

This will fix the exception message on unsupported driver.

For example Storage::disk('unsupported-disk');

Before
Driver [] is not supported.

After
Driver [unsupported-disk] is not supported.

[driesvints]

Neat 👍

[arcanedev-maroc]

@driesvints Done 👍

[arcanedev-maroc]

Note: Failed test not related

Hi @driesvints, i was wondering how to mock the config repository so i check the other tests.

I found that the $this->assert***() (PHPUnit asserts) are not called as a static method 👀

UPDATE
How to solve this https://travis-ci.org/laravel/framework/jobs/599655857#L589-L595 ? Return array instead of null ?

[driesvints]

@arcanedev-maroc think the tests are definitely related and that the problem is just that you need to rewrite this line:

$app['config'] = ['filesystems.disks.unsupported-disk' => null];

to this?

$app['config'] = ['filesystems.disks' => []];

[arcanedev-maroc]

@driesvints How about this change ?

[arcanedev-maroc]

Interesting, something changed in arrays for PHP 7.4 🤔

Update:

@driesvints Try this in PHP 7.3 and 7.4 👀

$config = null;

dd($config['name']);

[netpok]

Related RFC about the null-array change

[taylorotwell]

Is this ready to merge? I don't know if the previous comments are saying there is a problem or what?

[netpok]

@taylorotwell I just checked and I think this merge should be reverted, this changes the driver resolution.

When a disk named local have no driver it thrown an exception in the previous version (through multiple levels of non-existing array keys). With this merge it will resolve to local driver.

I think the correct solution would be to check against the existence of the driver field and throw an exception with Disk [name] has no configured driver instead of resolving by its name.

Also it will try to create drivers for non existing disks: if filesystems.php has no disk named local the Storage::disk('local') will still try to create a local disk (actually it will fail because it tries to pass a null to a method which has an array typehint, but that's an other story).