[6.x] Add the ability to delete a resolved log driver/channel #30132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
morloderex
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backstory:
I am currently working on a little multi-tenancy project. In order for me to ease the development i did a little research and found the tenancy/tenancy origanisation was building a new package(s). Specifically tailored to my needs. It is not released yet. So I thought i might help them out with the development of it.
Motivation:
By doing some digging into their implementation of their log affect, I discovered that they are trying to delete the resolved channel/driver at runtime in order for the logging to be recreated for the same driver/channel but with different configuration keys/values.
But they currently have to recreate the entire LogManager instance as the LogManager currently does not have the ability to delete a resolved channel. I found that we have a purge method (aliased to disconnect) on the DatabaseManager. So i figured why not make it possible here as well?
This is what this pr is all about, the ability to delete a resolved log channel/driver.