ShouldBeUnique with DynamoDB provider doesn't work as expected with default configuration

[wowu]

• Laravel Version: v9.19.0
• PHP Version: 8.1.6

Description:

According to documentation, implementing ShouldBeUnique on job class is enough to ensure only one instance of given job is present in the queue. However, using dynamodb cache driver without setting $uniqueFor explicitly makes the lock item expire after 1 second, because expires_at is set to current timestamp when $uniqueFor is 0 (default value).

This is the change event in DynamoDB table after putItem request when trying to acquire job lock:

{
  "awsRegion": "eu-central-1",
  "eventID": "4cb2d5b3-4954-451e-8332-01671dd2bf3e",
  "eventName": "INSERT",
  "userIdentity": null,
  "recordFormat": "application/json",
  "tableName": "vapor_cache",
  "dynamodb": {
    "ApproximateCreationDateTime": 1658222276198,
    "Keys": {
      "key": {
        "S": "cloud-api-production:cloud-api-production:laravel_unique_job:App\\Jobs\\<job-name>"
      }
    },
    "NewImage": {
      "value": {
        "S": "s:16:\"D7X1915ojxbQW6sU\";"
      },
      "key": {
        "S": "cloud-api-production:cloud-api-production:laravel_unique_job:App\\Jobs\\<job-name>"
      },
      "expires_at": {
        "N": "1658222276"
      }
    },
    "SizeBytes": 237
  },
  "eventSource": "aws:dynamodb"
}

expires_at is equal to current timestamp (see ApproximateCreationDateTime), so trying to acquire the lock in the following second will work because of used condition:

framework/src/Illuminate/Cache/DynamoDbStore.php

Line 273 in d425952

'ConditionExpression' => 'attribute_not_exists(#key) OR #expires_at < :now',

It seems like the behavior is not consistent across other cache providers, e.g. database cache provider uses lock expiration time of 1 day if no time was provided:

framework/src/Illuminate/Cache/DatabaseLock.php

Lines 92 to 95 in d425952

	protected function expiresAt()
	{
	return $this->seconds > 0 ? time() + $this->seconds : Carbon::now()->addDays(1)->getTimestamp();
	}

redis provider creates non-expiring item:

framework/src/Illuminate/Cache/RedisLock.php

Lines 35 to 42 in d425952

	public function acquire()
	{
	if ($this->seconds > 0) {
	return $this->redis->set($this->name, $this->owner, 'EX', $this->seconds, 'NX') == true;
	} else {
	return $this->redis->setnx($this->name, $this->owner) === 1;
	}
	}

memcached items doesn't expire with expiration time set to 0.

While dynamodb items expire in the next second after the lock is acquired.

Possible solution would be to use 1 day as default expiration value, as in database cache provider case.

Steps To Reproduce:

1. Use dynamodb cache provider
2. Create a job implementing ShouldBeUnique that takes longer than a few seconds to complete
3. Try to dispatch the job two times, more than 1 second apart
4. The job will be executed concurrently despite implementing ShouldBeUnique

Repository demonstrating the issue: https://github.com/Wowu/laravel-dynamodb-bug-report

[taylorotwell]

Can you make a PR to fix the issue?

[driesvints]

We merged a fix. Thanks!