Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dot is still allowed in validation rule digits_between #42540

Closed
taai opened this issue May 27, 2022 · 2 comments
Closed

Dot is still allowed in validation rule digits_between #42540

taai opened this issue May 27, 2022 · 2 comments

Comments

@taai
Copy link
Contributor

taai commented May 27, 2022

Description:

@taylorotwell decided to roll back commits that allowed to use dot (.) in validation rule digits_between (and digits), but forgot to roll back also this commit that started allowing that: #40278

Please, roll back also that commit!

@driesvints
Copy link
Member

Heya, I sent in a PR for that as well: #42562. Should get in before tomorrow's releases.

Thanks for your commitment to this but I also do hope you understand why I was initially against doing these changes as they could be breaking to users.

@taai
Copy link
Contributor Author

taai commented May 30, 2022

Thanks for your commitment to this but I also do hope you understand why I was initially against doing these changes as they could be breaking to users.

@driesvints You are doing a huge work reviewing all the issues and PRs - it is understandable that some decisions will be made in a hurry... I don't blame you - the one who wanted a dot to be accepted in the validation rule said that the dot was previously accepted, but he didn't say that "previously" was more than 5 years ago. 🤷‍♂️ Yes, the resistance from you on this issue was a surprise to me. But when you finally explained that the reason for rejection is possibility of breaking change, I stopped arguing and tried another approach (PR with the third validation rule argument strict). More surprised I was about carelessness of Taylor when he rejected my PR - I guess it is because he is busier than you are. 🤔 After that I turned on the trolling mode and posted my PR with validation rule float_between, because, in my opinion, the situation was ridiculous... No hard feelings?! 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants