You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@taylorotwelldecided to roll back commits that allowed to use dot (.) in validation rule digits_between (and digits), but forgot to roll back also this commit that started allowing that: #40278
Please, roll back also that commit!
The text was updated successfully, but these errors were encountered:
Heya, I sent in a PR for that as well: #42562. Should get in before tomorrow's releases.
Thanks for your commitment to this but I also do hope you understand why I was initially against doing these changes as they could be breaking to users.
Thanks for your commitment to this but I also do hope you understand why I was initially against doing these changes as they could be breaking to users.
@driesvints You are doing a huge work reviewing all the issues and PRs - it is understandable that some decisions will be made in a hurry... I don't blame you - the one who wanted a dot to be accepted in the validation rule said that the dot was previously accepted, but he didn't say that "previously" was more than 5 years ago. 🤷♂️ Yes, the resistance from you on this issue was a surprise to me. But when you finally explained that the reason for rejection is possibility of breaking change, I stopped arguing and tried another approach (PR with the third validation rule argument strict). More surprised I was about carelessness of Taylor when he rejected my PR - I guess it is because he is busier than you are. 🤔 After that I turned on the trolling mode and posted my PR with validation rule float_between, because, in my opinion, the situation was ridiculous... No hard feelings?! 😉
Description:
@taylorotwell decided to roll back commits that allowed to use dot (
.
) in validation ruledigits_between
(anddigits
), but forgot to roll back also this commit that started allowing that: #40278Please, roll back also that commit!
The text was updated successfully, but these errors were encountered: