WithoutMiddleware doesn't work on global middleware

[nmokkenstorm]

• Laravel Version: 7.6.1
• PHP Version: 7.3.16
• Database Driver & Version: N/A

Description:

A recent commit added the option to skip/disable middleware for specific routes, which works for Route Groups and the like, but the implementation for global middleware doesn't actually check for it yet. I'm willing to look into a fix for this, but wanted to raise an issue first to check if such a fix would be welcome.

Steps To Reproduce:

Require a Auth middleware for all your routes in the App\Http\Kernel, try to call ->withoutMiddleware on login.

[driesvints]

I'm not sure if it was intended to skip global middleware. You're free to attempt a pr however.

[driesvints]

Heya. I'm gonna re-open this as it indeed seems to be expected to work with global middleware as well. Thanks for reporting.

[nmokkenstorm]

@driesvints , @dsazup thanks for the feedback, I'd love to work on a PR for this tonight, will keep you both in the loop.

[driesvints]

Closing this as the PR was rejected. Please see the explanation by Taylor here: #32404 (comment)

[bernardwiesner]

btw you can exclude a global middleware like this inside Kernel.php

    public function handle($request)
    {
        if($request->is('/your/route')){
            $index = array_search(SomeMiddleware::class, $this->middleware);
            unset($this->middleware[$index]);
        }
        return parent::handle($request);
    }