Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Laravel 6 still uses stray instances of str_and array_ #30428

Closed
connecteev opened this issue Oct 25, 2019 · 4 comments
Closed

Laravel 6 still uses stray instances of str_and array_ #30428

connecteev opened this issue Oct 25, 2019 · 4 comments

Comments

@connecteev
Copy link

connecteev commented Oct 25, 2019 •
edited
Loading

  • Laravel Version: #.#.# 6.4
  • PHP Version: #.#.# 7.3
  • Database Driver & Version: MySQL 8

Description:

Laravel 6 still uses stray instances of str_and array_ when they should be removed.
See https://laravel.com/docs/6.x/upgrade#helpers

Steps To Reproduce:

After doing "laravel new myapp", I did a grep and found these:

$ grep -ri "array_" *
config/database.php:            'options' => extension_loaded('pdo_mysql') ? array_filter([
$ grep -ri "str_" *
resources/views/welcome.blade.php:<html lang="{{ str_replace('_', '-', app()->getLocale()) }}">
@it-can
Copy link
Contributor

it-can commented Oct 25, 2019

These are php functions not laravel helpers...

@connecteev
Copy link
Author

@it-can the documentation isn't very clear...

@devcircus
Copy link
Contributor

None of Laravel's helper methods are named the same as existing PHP functions, so there's no chance these are from laravel. You can see the available laravel helpers in the helpers package @ github.com/laravel/helpers

@connecteev
Copy link
Author

What I was looking for was a link to this in the docs.
https://laravel.com/docs/5.6/helpers
since these are the functions I need to search and replace.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@connecteev @it-can @devcircus