Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event:list throws an exception if the Listeners directory does not exist #28092

Closed
sebdesign opened this issue Apr 2, 2019 · 2 comments
Closed
Labels

Comments

@sebdesign
Copy link
Contributor

  • Laravel Version: 5.8.9
  • PHP Version: 7.2
  • Database Driver & Version: N/A

Description:

When running php artisan event:list that was introduced in #28085 on an application that doesn't have an app/Listeners directory,
an InvalidArgumentException is thrown from the in method of the Symfony Finder, because it can't find that directory.

I believe this exception will also occur in the EventServiceProvider when shouldDiscoverEvents returns true, because the DiscoverEvents class will be invoked.

Steps To Reproduce:

laravel new blog
cd blog
php artisan event:list
@driesvints driesvints added the bug label Apr 2, 2019
@driesvints
Copy link
Member

Ping @themsaid

@themsaid
Copy link
Member

themsaid commented Apr 3, 2019

opened a PR to exclude non-existing directories:

#28098

@themsaid themsaid closed this as completed Apr 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants