BoundMethod::call is broken.

[dkulyk]

• Laravel Version: 5.7.18
• PHP Version: 5.2
• Database Driver & Version: MariaDB 10.2

Steps To Reproduce:

\Illuminate\Hashing\HashManager - is an example.

app()->call(function(\Illuminate\Hashing\HashManager $hash){
}, ['log'=>'not a HashManager type']);

//Also
app()->call(function(\Illuminate\Hashing\HashManager $hash){
}, ['log' => 'not a HashManager type', 'hash' => new \Illuminate\Hashing\HashManager]);

Throws exception.

TypeError: Argument 1 passed to {closure}() must be an instance of Illuminate/Hashing/HashManager, string given

Works if:

• $log exists in function parameters;
• additional arguments is empty;

Related #26852

[driesvints]

Where/why are you calling the HashManager like that? I don't think it's suppose to work like this?

[imanghafoori1]

Is this kind of usage documented anywhere or is there any usage in laravel source code like this ?!

Anyway I get it, you expect the 'log' to be ignored automatically yes ?!

[gustavofabiane]

Like @dkulyk I was using the container 'call()' to call methods with parameter binding like in 'make/makeWith' (Here), where the given parameters array keys are checked with the reflected parameters names from class constructor to be injected automatically.

Actually this behavior still working in BoundMethod as previously expected but the parameter inversion in this commit breaks it.

This line in BoundMethod class (153) ensures it:

        if (array_key_exists($parameter->name, $parameters)) {
            $dependencies[] = $parameters[$parameter->name];

[Quintile]

After updating my Lumen app to include the BoundMethod change, controller injections have stopped working. If I go into BoundMethod.php and revert the changes made here: 881be81#diff-62fd60bbf5999df1027491ff843c6812L119 everything works again.

For example I've got a controller method:
public function destroy(Buckets $buckets, int $id): JsonResponse

With this commit, it throws an exception that destroy is expecting an instance of Buckets, but got string.

Once reverted, everything works as expected.

[sebastianmulders]

Same here. Spatie's event-projector is broken too because of the parameter inversion mentioned by @gustavofabiane. Related file: https://github.com/spatie/laravel-event-projector/blob/bbac6a7731910f38cb9d5f27961835a12ecd0ef3/src/EventHandlers/HandlesEvents.php#L36

[taylorotwell]

Reverted