Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RedisStore, cant set Redis::OPT_SERIALIZER to Redis::SERIALIZER_IGBINARY because of hardcoded serialization #26186

Closed
ReDev1L opened this issue Oct 19, 2018 · 4 comments
Labels

Comments

@ReDev1L
Copy link

ReDev1L commented Oct 19, 2018

  • Laravel Version: 5.7.+
  • PHP Version: 7.2.11
  • Database Driver & Version:
    PECL redis 4.1.1

Description:

Cant set Redis::OPT_SERIALIZER to any value, thats because of:
serialize
and
unserialize
methods in RedisStore.

Store needs refactor, to accept Redis::SERIALIZER_IGBINARY

@driesvints
Copy link
Member

This needs a little more info. What are you actually trying to do? Can you provide some code examples? How do the Redis options affect the linked code?

@ReDev1L
Copy link
Author

ReDev1L commented Nov 9, 2018

Laravel RedisStore implementation has php serialize() / unserialize() hardcoded. This prevents igbinary serialization of strings if option passed to phpredis

@driesvints
Copy link
Member

Ah I see. Yeah that should be made possible. Feel free to send in a PR if you know how to fix this.

@driesvints
Copy link
Member

#31182 has been merged so you can now set custom serializers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants