Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cashier\Invoice::isDeleted() method not working, Undefined constant STATUS_DELETED. #1521

Closed
xiCO2k opened this issue Apr 3, 2023 · 3 comments
Labels

Comments

@xiCO2k
Copy link
Contributor

xiCO2k commented Apr 3, 2023

  • Cashier Version: 14.9.0
  • Laravel Version: 10.5.1
  • PHP Version: 8.2.4
  • Stripe PHP Version: 10.12.0

Description:

After upgrading all my composer packages I got this error:

image

Looks like Stripe SDK removed the constant Stripe\Invoice::STATUS_DELETED.

This issue was introduced in the v10.12.0 release: https://github.com/stripe/stripe-php/releases/tag/v10.12.0

Cheers.

@driesvints
Copy link
Member

Thank you. I submitted a bug report for this with them: stripe/stripe-php#1474

@driesvints driesvints added the bug label Apr 4, 2023
@richardm-stripe
Copy link

We restored the enum value in https://github.com/stripe/stripe-php/releases/tag/v10.12.1. Sorry for the churn. We will remove this value in the next major version of stripe-php. The Stripe API doesn't actually return invoices with STATUS_DELETED though, so if you are relying on it you likely have dead code.

@driesvints
Copy link
Member

I'll also deprecate this method on current cashier and remove it in the next version. Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants