Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat altgr as Modifier #408

Merged
merged 2 commits into from
Apr 1, 2024
Merged

treat altgr as Modifier #408

merged 2 commits into from
Apr 1, 2024

Conversation

dzhou121
Copy link
Contributor

@dzhou121 dzhou121 commented Apr 1, 2024

No description provided.

@dzhou121 dzhou121 merged commit b538f39 into main Apr 1, 2024
7 checks passed
@dzhou121 dzhou121 deleted the altgr_as_modifier branch April 1, 2024 10:46
@dajoha
Copy link

dajoha commented Apr 20, 2024

Hello @dzhou121 , this PR makes the text editor totally unusable with a french keyboard. Indeed, inserting the following chars can be done only by using "AltGr":

~#{[|`\^@]}

And hitting a "AltGr+..." keystroke does not work anymore.

Maybe this can be fixed by just adding mods.set(Modifiers::ALTGR, false); here?

mods.set(Modifiers::SHIFT, false);

@dzhou121
Copy link
Contributor Author

Hello @dzhou121 , this PR makes the text editor totally unusable with a french keyboard. Indeed, inserting the following chars can be done only by using "AltGr":

~#{[|`\^@]}

And hitting a "AltGr+..." keystroke does not work anymore.

Maybe this can be fixed by just adding mods.set(Modifiers::ALTGR, false); here?

mods.set(Modifiers::SHIFT, false);

You are right. Fixed in main now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants