Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no static on re git #219

Merged
merged 3 commits into from
Jan 18, 2023
Merged

no static on re git #219

merged 3 commits into from
Jan 18, 2023

Conversation

Yurlungur
Copy link
Collaborator

@Yurlungur Yurlungur commented Jan 18, 2023

PR Summary

Github already builds pages and does format checking for us so there's no reason to duplicate this work on re-git. Currently WIP until I test the CI on re-git.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.
  • After creating a pull request, note it in the CHANGELOG.md file
  • If preparing for a new release, update the version in cmake.

@Yurlungur Yurlungur changed the title [WIP] no static on re git no static on re git Jan 18, 2023
@Yurlungur
Copy link
Collaborator Author

This appears to work and is faster by a fair margin than the version with static analysis.

@Yurlungur
Copy link
Collaborator Author

This appears to work and is faster by a fair margin than the version with static analysis.

Correction. It appears to work and is not faster at all than the version with static analysis on GPUs. All the time is spent elsewhere.

That said removing an unneeded part of the pipeline is probably still worthwhile.

@Yurlungur Yurlungur merged commit f893b41 into main Jan 18, 2023
@Yurlungur Yurlungur deleted the jmm/no-static-on-re-git branch January 18, 2023 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants