Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update spackage to use spack dependencies instead of submodules #146

Merged
merged 13 commits into from
Jul 8, 2022
Merged

Update spackage to use spack dependencies instead of submodules #146

merged 13 commits into from
Jul 8, 2022

Conversation

rbberger
Copy link
Collaborator

PR Summary

This PR and its Gitlab counterpart are used to prepare singularity-eos and its spackage to be upstreamed to spack/spack.

PR Checklist

  • Adds a test for any bugs fixed. Adds tests for new features.
  • Format your changes by using the make format command after configuring with cmake.
  • Document any new features, update documentation for changes made.
  • Make sure the copyright notice on any files you modified is up to date.

@Yurlungur
Copy link
Collaborator

@rbberger this is listed as WIP. Is it ready for review?

@rbberger rbberger force-pushed the rbberger/spackage_new_deps branch from c7d755b to 579aa60 Compare July 7, 2022 21:35
@rbberger rbberger changed the title WIP: Update spackage to use spack dependencies instead of submodules Update spackage to use spack dependencies instead of submodules Jul 7, 2022
@rbberger
Copy link
Collaborator Author

rbberger commented Jul 7, 2022

@Yurlungur ready for review. once merged, we need to change the references to this branch back to main. both in .gitlab-ci.yml and the singularity-eos/package.py.

Yurlungur
Yurlungur approved these changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@Yurlungur Yurlungur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

spack-repo/packages/spiner/package.py
maintainers = ['rbberger']

version("main", branch="main")
version('1.4.0', sha256='c3801b9eab26feabec33ff8c59e4056f384287f407d23faba010d354766f3ac5')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to change this now, but there's now a v1.5.1 for spiner now.

@Yurlungur
Copy link
Collaborator

I'll merge as soon as tests on re-git pass.

@Yurlungur Yurlungur self-assigned this Jul 7, 2022
@Yurlungur Yurlungur added the enhancement New feature or request label Jul 7, 2022
@rbberger rbberger force-pushed the rbberger/spackage_new_deps branch from c2ce32d to 2aa1fe1 Compare July 7, 2022 22:20
@rbberger rbberger force-pushed the rbberger/spackage_new_deps branch from 2aa1fe1 to 7e97cfc Compare July 7, 2022 22:28
@Yurlungur Yurlungur merged commit 143c3eb into main Jul 8, 2022
@Yurlungur Yurlungur deleted the rbberger/spackage_new_deps branch July 8, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yurlungur Yurlungur Yurlungur approved these changes

Assignees

@Yurlungur Yurlungur

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rbberger @Yurlungur