Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smaller default variant #445

Closed
Yurlungur opened this issue Dec 17, 2024 · 4 comments · Fixed by #444
Closed

Smaller default variant #445

Yurlungur opened this issue Dec 17, 2024 · 4 comments · Fixed by #444
Assignees

Comments

@Yurlungur
Copy link
Collaborator

Given we now have additional infrastructure for automatically building custom variants, I wonder if we should shrink the default variant by removing EOS models not needed by the fortran codes we support. In particular, I think I will avoid providing the 3T EOS's for now, until that point in integration is reached.

Similarly, I wonder if we should remove the EOS's mainly used for V&V from the default variant, e.g., Carnahan Starling, Stiff Gas, etc. We could hide them behind a build option potentially. What do you think, @jhp-lanl ?

@Yurlungur Yurlungur self-assigned this Dec 17, 2024
@jhp-lanl
Copy link
Collaborator

We could move to just injecting the variant right? Even with the Fortran codes we support, I think it's reasonable to ask them to keep around a header file that can define the Variant they want to use.

@Yurlungur
Copy link
Collaborator Author

Yeah---we're already in a place to support that from a build system perspective. We do currently provide a default variant, however, and I think it makes sense to keep some sensible default around.

@jhp-lanl
Copy link
Collaborator

Yeah---we're already in a place to support that from a build system perspective. We do currently provide a default variant, however, and I think it makes sense to keep some sensible default around.

Yeah that's true. But I'm just saying I don't think we need the host codes to necessarily determine the variant, and perhaps we want to think of the default variant in a different light. For example, maybe the default variant should just be what's needed to support the existing python bindings.

@Yurlungur
Copy link
Collaborator Author

A reasonable point. Do you think that merits leaving it as is? Or shrinking it a bit?

@Yurlungur Yurlungur linked a pull request Dec 18, 2024 that will close this issue
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants