Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to catch2 v3? #309

Closed
Yurlungur opened this issue Oct 12, 2023 · 5 comments
Closed

Move to catch2 v3? #309

Yurlungur opened this issue Oct 12, 2023 · 5 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Testing Additions/changes to the testing infrastruture

Comments

@Yurlungur
Copy link
Collaborator

At some point it may be worth modernizing our test infrastructure by moving from v2 of catch2 to v3. v3 is not header-only, it's more a proper static library, which should speed up compilation/linking times, as the entire catch library doesn't need to be built/linked per translation unit.

My question for you all is: what are the impediments to doing so from the perspective of our tooling?

  • @mauneyc-LANL you have a comment in the singularity-eos build that v2.13.7 is the version of catch that works with clang/newer compilers. Is this a problem for updating to newer catch?
  • Similarly, do we need update Spiner and ports-of-call to newer catch if we want singularity-eos updated?
  • Finally, for spack, is it enough to change the target in the spackage? Or do we need to install catch v3 on the CI shared spack? (Question for @ktsai7 or @rbberger )
@Yurlungur Yurlungur added enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Testing Additions/changes to the testing infrastruture labels Oct 12, 2023
@Yurlungur Yurlungur self-assigned this Oct 12, 2023
@ktsai7
Copy link
Contributor

ktsai7 commented Oct 13, 2023

@Yurlungur if you change the dependency to [email protected] in the spackage, it will get pulled in and installed during CI, so it shouldn't stop your development

The CI will be slightly slower since it has to build the [email protected] inflight until the next regular deployment cycle that pulls in the updated newer spackage after the spackaage has been merged in. If this slowed down is too much, then let me know and I can trigger a manual deployment update to pull the package in.

@dholladay00
Copy link
Collaborator

Isn't this now completed @Yurlungur ?

@Yurlungur
Copy link
Collaborator Author

No this is the one thing I didn't get to when messing with the tests.

@dholladay00
Copy link
Collaborator

This is now done correct?

@Yurlungur
Copy link
Collaborator Author

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed Testing Additions/changes to the testing infrastruture
Projects
None yet
Development

No branches or pull requests

3 participants