Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Path to Phoebus Refactor for Performance on Small Blocks #194

Open
1 of 3 tasks
Yurlungur opened this issue Dec 14, 2023 · 0 comments
Open
1 of 3 tasks

Path to Phoebus Refactor for Performance on Small Blocks #194

Yurlungur opened this issue Dec 14, 2023 · 0 comments
Assignees

Comments

@Yurlungur
Copy link
Collaborator

  • Move all variable names from strings to types
  • Port each kernel from using legacy packs (pm->PackVariables) to sparse packs (desc = MakePackDescriptor) and replace index gymnastics with typed accesses
  • Move each function from depending on MeshBlockData to depending on MeshData and move it from the async region in the driver to the sync region. Be careful to ensure dependencies are met!

The second and third steps can be done piece by piece, function by function. And step 2 can be done independently of step 3. However step 3 generically depends on step 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants