Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify non dimensionalization constants (?) #13

Open
rb004f opened this issue Oct 30, 2020 · 1 comment · Fixed by #21
Open

Unify non dimensionalization constants (?) #13

rb004f opened this issue Oct 30, 2020 · 1 comment · Fixed by #21

Comments

@rb004f
Copy link
Contributor

rb004f commented Oct 30, 2020

@kaarthiksundar It looks like we have a lot of non dimensionalization constants for units in the same dimension. For example, base_head, base_length, base_diameter, and base_elevation are all in m. If these have different non-dimensionalization constants do we run into potential bugs down the road where things could get out of whack? Would it make sense to have one constant per unit? Just a thought...

@kaarthiksundar
Copy link
Collaborator

@rb004f It makes sense to just have one.

@rb004f rb004f linked a pull request Nov 9, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants