Runnables: Add .map() method #9445
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
the
🤖:improvement
nfcampos
force-pushed
the
nc/runnables-each
branch
from
04cd3a0 to
0f2abc4
Compare
nfcampos
force-pushed
the
nc/runnables-each
branch
from
7eab95c to
bba4ddc
Compare
| @@ -208,6 +208,12 @@ def bind(self, **kwargs: Any) -> Runnable[Input, Output]: | |||
| """ | |||
| return RunnableBinding(bound=self, kwargs=kwargs) | |||
|
|
|||
| def each(self) -> Runnable[List[Input], List[Output]]: | |||
There was a problem hiding this comment.
Is there a better name for this?
There was a problem hiding this comment.
Sort of looks like .map to me?
| def lc_namespace(self) -> List[str]: | ||
| return self.__class__.__module__.split(".")[:-1] | ||
|
|
||
| def each(self) -> RunnableEach[Input, Output]: # type: ignore[override] |
There was a problem hiding this comment.
Mypy isn't super smart here
There was a problem hiding this comment.
Any reason not to return Runnable[List[Input], List[Output]] wouldn't this preserve the correct interface?
Otherwise, could you leave a comment in the code explaining the need for this type ignore?
There was a problem hiding this comment.
The problem is Mypy wants this to be Runnable[List[List[Input]], List[List[Output]]]
There was a problem hiding this comment.
Unfortunately I think mypy is correct here:
Runnable.maphas a signature of-> Runnable[List[Input], List[Output]].RunnableEach[I, O]is aRunnable[List[I], List[O]].- That means that in order to subtype
Runnable,RunnableEach[I, O].maphas to be-> Runnable[List[List[I]], List[List[O]]].
I think this might cause further issues in downstream code, both inside langchain and in downstream packages that depend on it.
It feels like RunnableEach shouldn't be Runnable, and perhaps there's a missing abstraction that should sit underneath both of them?
nfcampos
force-pushed
the
nc/runnables-shared-executor
branch
from
68535ef to
fcb0fbe
Compare
| def lc_namespace(self) -> List[str]: | ||
| return self.__class__.__module__.split(".")[:-1] | ||
|
|
||
| def each(self) -> RunnableEach[Input, Output]: # type: ignore[override] |
There was a problem hiding this comment.
Any reason not to return Runnable[List[Input], List[Output]] wouldn't this preserve the correct interface?
Otherwise, could you leave a comment in the code explaining the need for this type ignore?
libs/langchain/tests/unit_tests/schema/runnable/test_runnable.py
Outdated
Show resolved
Hide resolved
nfcampos
force-pushed
the
nc/runnables-each
branch
from
bba4ddc to
937e27f
Compare
nfcampos
force-pushed
the
nc/runnables-shared-executor
branch
from
fcb0fbe to
db4b256
Compare
nfcampos
force-pushed
the
nc/runnables-each
branch
from
345dc6e to
ab9f7b5
Compare
nfcampos
force-pushed
the
nc/runnables-each
branch
from
ab9f7b5 to
882b97c
Compare
No description provided.