Harrison/standard llm interface #4615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyurtsev
reviewed
May 13, 2023
langchain/base_language.py
Outdated
| @@ -51,6 +51,16 @@ async def agenerate_prompt( | |||
| ) -> LLMResult: | |||
| """Take in a list of prompt values and return an LLMResult.""" | |||
|
|
|||
| @abstractmethod | |||
| def predict(self, text: str, stop: Optional[List[str]] = None) -> str: | |||
There was a problem hiding this comment.
Use * after positional args
Change list to sequence
the default should be to get rid of all List types on all inputs
langchain/base_language.py
Outdated
|
|
||
| @abstractmethod | ||
| def predict_messages( | ||
| self, messages: List[BaseMessage], stop: Optional[List[str]] = None |
There was a problem hiding this comment.
- Use * after positional args
- Change list to sequence in input
langchain/chat_models/base.py
Outdated
| result = self([HumanMessage(content=message)], stop=stop) | ||
| return self.predict(message, stop=stop) | ||
|
|
||
| def predict(self, text: str, stop: Optional[List[str]] = None) -> str: |
There was a problem hiding this comment.
Same comment as above for function signature
hwchase17
added a commit
that referenced
this pull request
May 24, 2023
# Add async versions of predict() and predict_messages() #4615 introduced a unifying interface for "base" and "chat" LLM models via the new `predict()` and `predict_messages()` methods that allow both types of models to operate on string and message-based inputs, respectively. This PR adds async versions of the same (`apredict()` and `apredict_messages()`) that are identical except for their use of `agenerate()` in place of `generate()`, which means they repurpose all existing work on the async backend. ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @hwchase17 (follows his work on #4615) @agola11 (async) --------- Co-authored-by: Harrison Chase <[email protected]>
vowelparrot
pushed a commit
that referenced
this pull request
May 24, 2023
# Add async versions of predict() and predict_messages() #4615 introduced a unifying interface for "base" and "chat" LLM models via the new `predict()` and `predict_messages()` methods that allow both types of models to operate on string and message-based inputs, respectively. This PR adds async versions of the same (`apredict()` and `apredict_messages()`) that are identical except for their use of `agenerate()` in place of `generate()`, which means they repurpose all existing work on the async backend. ## Who can review? Community members can review the PR once tests pass. Tag maintainers/contributors who might be interested: @hwchase17 (follows his work on #4615) @agola11 (async) --------- Co-authored-by: Harrison Chase <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.