Fix missing self argument in _get_docs_with_query method of `Cust…
#26312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…omSelfQueryRetriever` This commit corrects an issue in the `_get_docs_with_query` method of the `CustomSelfQueryRetriever` class. The method was incorrectly using `self.vectorstore.similarity_search_with_score(query, **search_kwargs)` without including the `self` argument, which is required for proper method invocation. The `self` argument is necessary for calling instance methods and accessing instance attributes. By including `self` in the method call, we ensure that the method is correctly executed in the context of the current instance, allowing it to function as intended. No other changes were made to the method's logic or functionality.
dosubot
bot
added
the
size:XS
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dosubot
bot
added
Ɑ: retriever
efriis
approved these changes
Sep 16, 2024
dosubot
bot
added
the
lgtm
Sheepsta300
pushed a commit
to Sheepsta300/langchain
that referenced
this pull request
Oct 1, 2024
… `Cust… (langchain-ai#26312) …omSelfQueryRetriever` This commit corrects an issue in the `_get_docs_with_query` method of the `CustomSelfQueryRetriever` class. The method was incorrectly using `self.vectorstore.similarity_search_with_score(query, **search_kwargs)` without including the `self` argument, which is required for proper method invocation. The `self` argument is necessary for calling instance methods and accessing instance attributes. By including `self` in the method call, we ensure that the method is correctly executed in the context of the current instance, allowing it to function as intended. No other changes were made to the method's logic or functionality. Thank you for contributing to LangChain! - [ ] **PR title**: "package: description" - Where "package" is whichever of langchain, community, core, experimental, etc. is being modified. Use "docs: ..." for purely docs changes, "templates: ..." for template changes, "infra: ..." for CI changes. - Example: "community: add foobar LLM" - [ ] **PR message**: ***Delete this entire checklist*** and replace with - **Description:** a description of the change - **Issue:** the issue # it fixes, if applicable - **Dependencies:** any dependencies required for this change - **Twitter handle:** if your PR gets announced, and you'd like a mention, we'll gladly shout you out! - [ ] **Add tests and docs**: If you're adding a new integration, please include 1. a test for the integration, preferably unit tests that do not rely on network access, 2. an example notebook showing its use. It lives in `docs/docs/integrations` directory. - [ ] **Lint and test**: Run `make format`, `make lint` and `make test` from the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/ Additional guidelines: - Make sure optional dependencies are imported within a function. - Please do not add dependencies to pyproject.toml files (even optional ones) unless they are required for unit tests. - Most PRs should not touch more than one package. - Changes should be backwards compatible. - If you are adding something to community, do not re-import it in langchain. If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17. Co-authored-by: Erick Friis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…omSelfQueryRetriever`
This commit corrects an issue in the
_get_docs_with_querymethod of theCustomSelfQueryRetrieverclass. The method was incorrectly usingself.vectorstore.similarity_search_with_score(query, **search_kwargs)without including theselfargument, which is required for proper method invocation.The
selfargument is necessary for calling instance methods and accessing instance attributes. By includingselfin the method call, we ensure that the method is correctly executed in the context of the current instance, allowing it to function as intended.No other changes were made to the method's logic or functionality.
Thank you for contributing to LangChain!
PR title: "package: description"
PR message: Delete this entire checklist and replace with
Add tests and docs: If you're adding a new integration, please include
docs/docs/integrationsdirectory.Lint and test: Run
make format,make lintandmake testfrom the root of the package(s) you've modified. See contribution guidelines for more: https://python.langchain.com/docs/contributing/Additional guidelines:
If no one reviews your PR within a few days, please @-mention one of baskaryan, efriis, eyurtsev, ccurme, vbarda, hwchase17.