Enhance GoogleDriveLoader to Support Spreadsheets when loading documents from ids (issue #3637) #12308
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: doc loader
lumenintellects
changed the title
lumenintellects
changed the title
lumenintellects
changed the title
|
Hello @baskaryan, thank you for reopening this. If you plan to review and merge, I can resolve the conflict by moving the code to langchain_community accordingly. Let me know please, have a nice day! |
|
Thanks for creating this MR. I'm looking into read the spreadsheet with user input spreadsheet URL. Wonder if we could get this MR review and merge into the master anytime soon. Otherwisem I might need to redo this implementation by my own. |
ccurme
added
community
| .get(fileId=doc_id, fields="id,mimeType", supportsAllDrives=True) | ||
| .execute() | ||
| ) | ||
| documents.extend(self._process_document_by_mimetype(file_data)) |
There was a problem hiding this comment.
Previously we went straight to _load_document_from_id for document types. Now we have some extra overhead where we fetch the file data, pluck out the id, and pass the ID to _load_document_from_id (which appears to pull the file again).
- Is this overhead necessary? Will it introduce latency for users?
- Is the new output from
_load_documents_from_idsidentical to previous behavior for existing supported document types?
|
Closing but will re-open if there's desire to keep iterating, let me know! |
Issue: [#3637]
Summary:
The codebase includes a private method
_load_sheet_from_idthat can handle Google Sheets, which is currently only invoked when loading documents from a folder. This PR aims to unify the document loading approach, ensuring both individual IDs and folders consider themimeTypeto determine the document type.Changes:
_process_file_by_mimetypefunction to handle the processing logic based on filemimeType, reducing code repetition._load_documents_from_idsand_load_documents_from_folderto utilize the new_process_file_by_mimetypefunction, ensuring consistent behavior.Reminder
If no one reviews your PR within a few days, please @-mention one of @baskaryan, @eyurtsev, @hwchase17.