Create new RunnableSerializable base class in preparation for configurable runnables #11279
Conversation
nfcampos
commented
Oct 2, 2023
nfcampos
commented
- Also move RunnableBranch to its own file
… runnables - Also move RunnableBranch to its own file
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
dosubot
bot
added
Ɑ: models
nfcampos
changed the title
| @@ -119,6 +122,24 @@ def output_schema(self) -> Type[BaseModel]: | |||
| self.__class__.__name__ + "Output", __root__=(root_type, None) | |||
| ) | |||
|
|
|||
| def config_schema( | |||
| self, *, include: Optional[Sequence[str]] = None | |||
There was a problem hiding this comment.
Could you explain where this comes into play? This looks like the change I needed for remote runnables, but for that case I'm not sure I would've wanted the config defined as a method on runnables since config doesn't vary by runnable
There was a problem hiding this comment.
It will make sense in the next PR :) #11282
|
|
||
| from langchain.load.dump import dumpd | ||
| from langchain.pydantic_v1 import BaseModel | ||
| from langchain.schema.runnable.base import Runnable, RunnableSerializable |
There was a problem hiding this comment.
is_lcserializable is a class method, so I think inheritance will work, we could define it such that anything that inherits from RunnableSerializable is in fact serializable and also provide a default namespace
There was a problem hiding this comment.
I think that's going a bit too far for now, but would be useful in the future
|
This looks good! |
